[examples][now-static-build] Add Ionic Angular framework #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3970 +/- ##
==========================================
+ Coverage 13.12% 13.27% +0.14%
==========================================
Files 291 291
Lines 10328 10339 +11
Branches 1348 1334 -14
==========================================
+ Hits 1356 1372 +16
Misses 8879 8879
+ Partials 93 88 -5
Continue to review full report at Codecov.
|
styfle
reviewed
Mar 27, 2020
styfle
changed the title
|
@coetry You also need to add an entry to |
styfle
reviewed
Apr 6, 2020
| slug: 'ionic-react', | ||
| dependency: '@ionic/react', | ||
| buildCommand: 'react-scripts build', | ||
| getOutputDirName: async () => 'build', |
There was a problem hiding this comment.
Is it build or public because @now/frameworks has public.
cc @AndyBitz
There was a problem hiding this comment.
It's build for ionic-react
styfle
reviewed
Apr 6, 2020
styfle
reviewed
Apr 8, 2020
packages/now-static-build/test/fixtures/52-ionic-angular/now.json
Outdated
Show resolved
Hide resolved
added 3 commits
April 9, 2020 11:30
…into add-ionic-ng-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds framework config for Ionic Angular and also updates a mistake found in the dev script of Ionic React, which mistakenly was using the same dev script as Stencil.