Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix update command #4353

Merged
merged 2 commits into from May 12, 2020
Merged

[cli] Fix update command #4353

merged 2 commits into from May 12, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented May 12, 2020

The CLI name was updated but not the command.

This PR fixes the command to show the correct package name.

https://app.clubhouse.io/vercel/story/311/wrong-vercel-cli-package-name-being-rendered-in-the-update-message

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #4353 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4353      +/-   ##
==========================================
+ Coverage   14.51%   14.61%   +0.10%     
==========================================
  Files         294      294              
  Lines       10513    10523      +10     
  Branches     1311     1313       +2     
==========================================
+ Hits         1526     1538      +12     
+ Misses       8905     8904       -1     
+ Partials       82       81       -1     
Impacted Files Coverage Δ
src/util/get-update-command.ts 57.14% <0.00%> (+3.29%) ⬆️
src/util/pkg-name.ts 62.50% <0.00%> (+6.25%) ⬆️
src/util/metrics.ts 84.61% <0.00%> (+10.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc3744...949ac31. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 591c247 into master May 12, 2020
@kodiakhq kodiakhq bot deleted the fix-update-command-pkg-name branch May 12, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants