Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add logs when installing Runtimes in dev #4393

Merged
merged 2 commits into from May 15, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented May 15, 2020

This PR consolidates the npm install for Runtimes during vercel dev and adds some additional logging.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #4393 into master will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4393      +/-   ##
==========================================
- Coverage   14.27%   13.40%   -0.87%     
==========================================
  Files         293      293              
  Lines       10481    10361     -120     
  Branches     1314     1358      +44     
==========================================
- Hits         1496     1389     -107     
+ Misses       8902     8874      -28     
- Partials       83       98      +15     
Impacted Files Coverage Δ
src/util/dev/server.ts 56.40% <0.00%> (-4.43%) ⬇️
src/util/dev/builder-cache.ts 75.73% <0.00%> (-4.27%) ⬇️
src/util/output/create-output.ts 60.00% <0.00%> (+0.81%) ⬆️
src/util/metrics.ts 73.68% <0.00%> (+4.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad2efe...cd540b4. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 05539dc into master May 15, 2020
@kodiakhq kodiakhq bot deleted the add-log-install-runtimes branch May 15, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants