[build-utils] Fix Yarn 2 install argument order #4444

SagnikPradhan · 2020-05-21T05:04:04Z

Fix for Yarn Version 2 install error. Positioned the arguments array in proper order #4436

Fix for Yarn Version 2. Positioned the arguments array in proper order

MarkLyck · 2020-05-21T13:55:11Z

styfle · 2020-05-21T18:16:56Z

packages/now-build-utils/src/fs/run-user-scripts.ts

@@ -291,7 +291,7 @@ export async function runNpmInstall(
  } else {
    opts.prettyCommand = 'yarn install';
    command = 'yarn';
-    commandArgs = args.concat(['install', '--ignore-engines']);
+    commandArgs = ['install', ...args, '--ignore-engines'];


Thanks! Please add a test fixture under now-build-utils/test/fixtures so we can see what this is fixing.

So from what I understand I have to add a sample project with yarn 2 there right?

Yes, you would add a project that would fail with the current behavior but is fixed with your change to the arguments.

I'm guessing you have yarn 2 as a dev dependency?

~~The original description doesn't explain how to reproduce the error or what the error says.~~

Update: I just saw #4436.

You can add the code from your repo as a test fixture.

But it doesn't install yarn 2?

@styfle Yarn 2 works in an interesting way.

The version that's installed is actually yarn 1.22 (usually this is installed globally not as a dev dependency), but you set it to use Yarn 2 in the project level by running the command yarn set version berry which then sets up that project to use the latest yarn version.

I think it should still be reproducible in a sample project I think, due to yarn installing Yarn 2 in the .yarn folder.

Yes @MarkLyck is kinda right, globally any version can be installed, but then you can also have an another local version installed in the .yarn folder and point to it through the .yarnrc (in case of v2 .yarnrc.yml) file. This behavior is not specific to yarn v2, you can try doing yarn set version latest in an non v2 project too.

Thus, generally, projects using v2 have it installed locally, with the help of yarn set version berry.

And Alright will be spinning up the default demo project with yarn v2!

@styfle Added a Template Svelte project with yarn v2

phuctm97 · 2020-05-24T01:04:18Z

How this PR is going, guys? I really need it. Anything I can help? I see some checks are failing.

SagnikPradhan · 2020-05-24T01:36:36Z

How this PR is going, guys? I really need it. Anything I can help? I see some checks are failing.

Most of the tests are failing because of being a 3rd Party PR. Although not sure about why Unit / Unit (macos-latest, 10) (pull_request) failed, maybe because of Github acting weird? IDK

Anyway waiting for @styfle and @AndyBitz for review

SagnikPradhan · 2020-05-25T22:28:00Z

Can someone look into this? It is a fairly small PR, should not take more than 20 Minutes. The Fixture is the default template project too.

styfle · 2020-05-27T14:13:14Z

I ran the test locally and it is not passing.

  ● Should build "19-yarn-v2"

    expect(received).resolves.toBeDefined()

    Received promise rejected instead of resolved
    Rejected to value: [SyntaxError: JSON5: invalid character 'u' at 1:1]

We need to add a now.json or vercel.json file to the test fixture.

styfle · 2020-05-27T14:31:03Z

When I added vercel.json with the following:

{
  "version": 2,
  "builds": [
    { "src": "package.json", "use": "@vercel/static-build" }
  ],
  "probes": [
    { "path": "/", "mustContain": "Svelte app" }
  ]
}

I get an error:

Running "yarn run build"
Unknown Syntax Error: Command not found;

Is yarn run build not supported anymore?

Update: This too needed to move the --ignore-engines flag to the end.

styfle

Thanks! 🎉

SagnikPradhan · 2020-05-27T16:39:38Z

I still seem to get the same error, is the master branch deployed?

Follow up to #4444 that makes sure we run Next.js tests. This `--ignore-engines` flag was originally added in vercel/now-builders#463 as a workaround. We can remove it to make sure the version of Node selected will work with the dependencies. Removing the flag also makes sure that Yarn 2 will work properly, see #4444.

phuctm97 · 2020-05-28T02:50:40Z

When will this get deployed to Vercel production, guys?

styfle · 2020-05-28T19:23:43Z

This change is available on the canary channel npm install -g vercel@canary

MarkLyck · 2020-05-28T19:29:35Z

@styfle when will it be deployed to production? I solely use the GitHub app to deploy our sites, I don't think there's any way I can point that to canary?

styfle · 2020-05-28T19:58:11Z

It will be available in the next stable release in a few weeks or so

SagnikPradhan · 2020-05-28T23:37:23Z

@styfle Is there a way we could use canary builds during build process or deployments?

styfle · 2020-05-29T01:12:37Z

Git deployments don't have a way to opt-in to canary builds yet but we will add a flag in the future

SagnikPradhan · 2020-05-29T01:13:56Z

@styfle Is there any other way to deploy? Other than git deployments?

styfle · 2020-05-29T01:21:00Z

Yes with Vercel CLI. See my previous comment #4444 (comment)

Update run-user-scripts.ts

8f300dd

Fix for Yarn Version 2. Positioned the arguments array in proper order

SagnikPradhan requested review from AndyBitz and styfle as code owners May 21, 2020 05:04

styfle reviewed May 21, 2020

View reviewed changes

styfle added the area: build-utils label May 21, 2020

styfle changed the title ~~Fix Yarn Version 2 install errors on Build Process~~ [build-utils] Fix Yarn Version 2 install errors on Build Process May 21, 2020

Added Fixture for Yarn v2

5f49d94

Merge branch 'master' into fix/yarn-v2-build-error

00f3fae

styfle linked an issue May 27, 2020 that may be closed by this pull request

Yarn version 2 install errors out #4436

Closed

styfle added 3 commits May 27, 2020 11:40

Fix yarn run

e2d2a10

Fix test

d84e386

Merge branch 'master' into fix/yarn-v2-build-error

157f51e

vercel bot deployed to Preview May 27, 2020 15:42 View deployment

styfle approved these changes May 27, 2020

View reviewed changes

styfle changed the title ~~[build-utils] Fix Yarn Version 2 install errors on Build Process~~ [build-utils] Fix Yarn 2 install argument order May 27, 2020

styfle merged commit dd2399f into vercel:master May 27, 2020

styfle mentioned this pull request May 27, 2020

[build-utils] Remove --ignore-engines flag #4508

Merged

SagnikPradhan deleted the fix/yarn-v2-build-error branch May 28, 2020 04:26

SagnikPradhan mentioned this pull request May 31, 2020

Yarn version 2 install errors out #4436

Closed

dalinarkholin mentioned this pull request Jun 4, 2020

Monorepo example #3547

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build-utils] Fix Yarn 2 install argument order #4444

[build-utils] Fix Yarn 2 install argument order #4444

SagnikPradhan commented May 21, 2020

MarkLyck commented May 21, 2020

styfle May 21, 2020

SagnikPradhan May 21, 2020 •

edited

styfle May 22, 2020 •

edited

styfle May 22, 2020 •

edited

MarkLyck May 22, 2020

SagnikPradhan May 22, 2020

SagnikPradhan May 22, 2020 •

edited

phuctm97 commented May 24, 2020 •

edited

SagnikPradhan commented May 24, 2020

SagnikPradhan commented May 25, 2020

styfle commented May 27, 2020 •

edited

styfle commented May 27, 2020 •

edited

styfle left a comment

SagnikPradhan commented May 27, 2020

phuctm97 commented May 28, 2020

styfle commented May 28, 2020

MarkLyck commented May 28, 2020

styfle commented May 28, 2020

SagnikPradhan commented May 28, 2020

styfle commented May 29, 2020

SagnikPradhan commented May 29, 2020

styfle commented May 29, 2020

[build-utils] Fix Yarn 2 install argument order #4444

[build-utils] Fix Yarn 2 install argument order #4444

Conversation

SagnikPradhan commented May 21, 2020

MarkLyck commented May 21, 2020

styfle May 21, 2020

Choose a reason for hiding this comment

SagnikPradhan May 21, 2020 • edited

Choose a reason for hiding this comment

styfle May 22, 2020 • edited

Choose a reason for hiding this comment

styfle May 22, 2020 • edited

Choose a reason for hiding this comment

MarkLyck May 22, 2020

Choose a reason for hiding this comment

SagnikPradhan May 22, 2020

Choose a reason for hiding this comment

SagnikPradhan May 22, 2020 • edited

Choose a reason for hiding this comment

phuctm97 commented May 24, 2020 • edited

SagnikPradhan commented May 24, 2020

SagnikPradhan commented May 25, 2020

styfle commented May 27, 2020 • edited

styfle commented May 27, 2020 • edited

styfle left a comment

Choose a reason for hiding this comment

SagnikPradhan commented May 27, 2020

phuctm97 commented May 28, 2020

styfle commented May 28, 2020

MarkLyck commented May 28, 2020

styfle commented May 28, 2020

SagnikPradhan commented May 28, 2020

styfle commented May 29, 2020

SagnikPradhan commented May 29, 2020

styfle commented May 29, 2020

SagnikPradhan May 21, 2020 •

edited

styfle May 22, 2020 •

edited

styfle May 22, 2020 •

edited

SagnikPradhan May 22, 2020 •

edited

phuctm97 commented May 24, 2020 •

edited

styfle commented May 27, 2020 •

edited

styfle commented May 27, 2020 •

edited