[cli] Show npm output when failing to install Runtimes in vc dev
#4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `npm install` doesn't exit with 0, then log the output to the termial. This was already happening with `--debug` due to `stdio: "inherit"` when debug is enabled, so this change is really only relevant for the non-debug case. Before: ``` $ vc dev Vercel CLI 19.0.2-canary.13 dev (beta) — https://vercel.com/feedback Error! Command failed with exit code 1: npm install --save-exact --no-package-lock --no-audit --no-progress @now/build-utils@canary @vercel/build-utils@canary now-php@0.0.0 ``` After: ``` $ vc dev Vercel CLI 19.0.2-canary.13 dev (beta) — https://vercel.com/feedback npm ERR! code ETARGET npm ERR! notarget No matching version found for now-php@0.0.0. npm ERR! notarget In most cases you or one of your dependencies are requesting npm ERR! notarget a package version that doesn't exist. npm ERR! A complete log of this run can be found in: npm ERR! /Users/nrajlich/.npm/_logs/2020-06-08T18_41_58_190Z-debug.log Error! Command failed with exit code 1: npm install --save-exact --no-package-lock --no-audit --no-progress --color=always @now/build-utils@canary @vercel/build-utils@canary now-php@0.0.0 ```
styfle
reviewed
Jun 8, 2020
TooTallNate
commented
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
styfle
reviewed
Jun 8, 2020
AndyBitz
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
npm installdoesn't exit with 0, then log the output to thetermial.
This was already happening with
--debugdue tostdio: "inherit"when debug is enabled, so this change is really only relevant for the
non-debug case.
Before
After
Bad dependency:
No
npminstalled: