Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to not render no token error, prompt login instead #4659

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Fix to not render no token error, prompt login instead #4659

merged 4 commits into from
Jun 17, 2020

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Jun 15, 2020 •
edited

When auth.json exists but no token property exists in it, we currently render error like the following screenshot.
Screen Shot 2020-06-15 at 21 32 55

This PR fixes to prompt login instead.
Screen Shot 2020-06-15 at 21 28 09

@nkzawa nkzawa requested a review from TooTallNate as a code owner June 15, 2020 12:34
lucleray
lucleray previously approved these changes Jun 15, 2020
View reviewed changes
TooTallNate
TooTallNate reviewed Jun 15, 2020
View reviewed changes
Copy link
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test for this?

@nkzawa
Copy link
Contributor Author

nkzawa commented Jun 16, 2020

@TooTallNate done

@nkzawa nkzawa requested a review from TooTallNate June 16, 2020 04:39
@TooTallNate TooTallNate added automerge triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked area: cli labels Jun 17, 2020
@kodiakhq kodiakhq bot merged commit d7731d1 into master Jun 17, 2020
@kodiakhq kodiakhq bot deleted the fix-no-token-error branch June 17, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@lucleray lucleray lucleray approved these changes

Assignees
No one assigned
Labels
area: cli triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkzawa @TooTallNate @lucleray