Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Update revalidate tests and correct shared lambdas revalidate #4704

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 23, 2020

This adds more fine grained tests for our revalidate behavior to ensure pages are actually being updated instead of only checking the headers, it also corrects page lookups failing with shared lambdas enabled for dynamic pages using revalidate.

Closes: vercel/next.js#14497

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passing

@kodiakhq kodiakhq bot merged commit 1a4e1d2 into master Jun 24, 2020
@kodiakhq kodiakhq bot deleted the ijjk/next/revalidate-shared-lambdas branch June 24, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revalidate fails with @vercel/next shared lambda mode
3 participants