[cli][build-utils] Refactor ajv error message #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
approved these changes
Jun 24, 2020
TooTallNate
reviewed
Jun 24, 2020
| error.message, | ||
| 'Invalid vercel.json - property `routes` should be of type array.' | ||
| ); | ||
| t.deepEqual(error.message, 'Invalid vercel.json - `routes` should be array.'); |
There was a problem hiding this comment.
All of these "should be" errors would read better to me if we prefixed "a"/"an" before the type. i.e. "should be an array".
AndyBitz
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #4694 so we can use this same helper function in the API.
I tried to follow the existing error message format so that the API can use a different prefix than the CLI.
The API currently returns a 400 with
Invalid requestwhen a Git deploy fails validation: