Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Add vercel link command #4897

Merged
merged 21 commits into from
Jul 21, 2020
Merged

[cli] Add vercel link command #4897

merged 21 commits into from
Jul 21, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Jul 21, 2020 •
edited

  • Add vercel link command
  • Update vercel dev to automatically link
  • Updated vercel env error message to mention vercel link
  • Test vercel link
  • Test vercel dev
  • Add --confirm flag

Related

@styfle styfle marked this pull request as ready for review July 21, 2020 17:05
@styfle styfle requested a review from AndyBitz July 21, 2020 20:23
AndyBitz
AndyBitz previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@AndyBitz AndyBitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :shipit:

MaxLeiter
MaxLeiter previously approved these changes Jul 21, 2020
View reviewed changes
@styfle styfle dismissed stale reviews from MaxLeiter and AndyBitz via bab044a July 21, 2020 21:55
@simonhaenisch
Copy link
Contributor

simonhaenisch commented Jul 21, 2020 •
edited

I quickly skimmed through the changes and it doesn't look like it's possible yet... would you consider adding the ability to specify an existing team scope and project with the command, e. g.

vercel link team/project

or is that not very straight-forward?

@styfle styfle merged commit 754090a into master Jul 21, 2020
@styfle styfle deleted the ch422/vercel-link branch July 21, 2020 22:52
@styfle
Copy link
Member Author

styfle commented Jul 21, 2020

@simonhaenisch No that was not implemented. That's a good suggestion, thanks!

@styfle styfle mentioned this pull request Jul 22, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Jul 22, 2020
@styfle
[cli] Update "set up" message (#4907)
963de9b 
Follow up to #4897 

* `vc link` - Update message to say `Set up ~/proj`
* `vc dev` - Update message  to say `Set up and develop ~/proj`
* `vc link --help` - Updated example message to include `vc link ~/proj` usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@AndyBitz AndyBitz AndyBitz approved these changes

@lucleray lucleray Awaiting requested review from lucleray

@rdev rdev Awaiting requested review from rdev

@MaxLeiter MaxLeiter Awaiting requested review from MaxLeiter

Assignees
No one assigned
Labels
area: cli area: dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[now dev] Error! Your codebase isn’t linked to a project on ZEIT Now.
5 participants
@styfle @simonhaenisch @TooTallNate @MaxLeiter @AndyBitz