[client] Export buildFileTree() and return the ignore list
#4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ignore list from this function will be used in production to render a warning if there are files listed in the `.vercelignore` file that are being comitted to the project's git repo.
TooTallNate
commented
Jul 24, 2020
styfle
reviewed
Jul 24, 2020
styfle
reviewed
Jul 24, 2020
styfle
reviewed
Jul 24, 2020
| @@ -81,17 +81,24 @@ export async function buildFileTree( | |||
| path: string | string[], | |||
| isDirectory: boolean, | |||
| debug: Debug | |||
There was a problem hiding this comment.
Are we going to be able to use this debug() command during the build?
There was a problem hiding this comment.
I was able to just pass console.log to it in a local script and typescript didn't complain, so I think we can pass it basically any function that accepts a string argument.
styfle
reviewed
Jul 24, 2020
Co-authored-by: Steven <steven@ceriously.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ignore list from this function will be used in production to
render a warning if there are files listed in the
.vercelignorefilethat are being committed to the project's git repo.