Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path alias updates #493

Merged
merged 2 commits into from May 4, 2017
Merged

Fix path alias updates #493

merged 2 commits into from May 4, 2017

Conversation

jamo
Copy link
Contributor

@jamo jamo commented May 3, 2017

It seems that path alias updates ended up trying to update alias instead of updating path alias

On top of current master path alias update looks like this:

 node  ./bin/now-alias.js zeit.ninja -r rules.json
> Error! No deployments found for "now"

@jamo jamo requested review from matheuss and leo May 3, 2017 18:21
@matheuss
Copy link
Member

matheuss commented May 4, 2017

🙏

@matheuss matheuss merged commit 9e22ad3 into master May 4, 2017
@matheuss matheuss deleted the fix/path-alias-updates branch May 4, 2017 23:17
TooTallNate added a commit that referenced this pull request Aug 23, 2019
@TooTallNate
[now-next] Default NODE_ENV to "development" for dev server (#493)
c030fce
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
Open
@zachlewis2020 zachlewis2020 mentioned this pull request Oct 1, 2023
Open
@nicholasklem nicholasklem mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheuss matheuss Awaiting requested review from matheuss

@leo leo Awaiting requested review from leo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamo @matheuss