[routing-utils] Update header replacing to handle more cases #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Jul 28, 2020
styfle
reviewed
Jul 28, 2020
This was referenced Jul 28, 2020
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2020
Instead of trying to parse header values as URLs and then replace path segments in them this switches to escaping characters that can break `path-to-regexp` compiling Fixes: #15580 x-ref: vercel/vercel#4942
Timer
approved these changes
Jul 29, 2020
|
@ijjk Don't forget to update the API repo after publishing canary 👍 |
LauraBeatris
pushed a commit
to LauraBeatris/next.js
that referenced
this pull request
Sep 1, 2020
Instead of trying to parse header values as URLs and then replace path segments in them this switches to escaping characters that can break `path-to-regexp` compiling Fixes: vercel#15580 x-ref: vercel/vercel#4942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handling for more cases while updating header values to make sure to escape any characters that could break compiling with
path-to-regexpx-ref: vercel/next.js#15592