-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli][client] (Major) Remove legacy Now CLI 1.0 code #5011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxLeiter
requested review from
AndyBitz,
rdev,
styfle and
TooTallNate
as code owners
August 7, 2020 23:43
MaxLeiter
changed the title
Remove Now CLI 1.0 code
[cli] [client] [Major] Remove legacy Now CLI 1.0 code
Aug 7, 2020
This reverts commit 8db5d74.
TooTallNate
previously approved these changes
Aug 12, 2020
styfle
reviewed
Aug 12, 2020
styfle
reviewed
Aug 12, 2020
styfle
reviewed
Aug 12, 2020
styfle
reviewed
Aug 12, 2020
Co-authored-by: Steven <steven@ceriously.com>
TooTallNate
previously approved these changes
Aug 12, 2020
…mework/.dockerignore
styfle
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TooTallNate
approved these changes
Aug 12, 2020
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 17, 2020
This PR is a follow up to removing v1 in PR #5011
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
`vc ls --help` was still listing an example using `--all` which was removed with Now 1.0 in PR #5011. This PR removes that legacy example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was easier to make a new PR than re-base the old ones:
#4017
#4602
Story: https://app.clubhouse.io/vercel/story/425/remove-all-the-zeit-now-1-0-code-from-vercel-cli