Always scale up but never down when matching scale on alias #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamo
force-pushed
the
improve/scale-on-alias
branch
from
8688eca
to
da21c5b
Compare
jamo
changed the title
TooTallNate
pushed a commit
that referenced
this pull request
Aug 23, 2019
* [now-go] Ignore folders in `analyze.go` (#503)(#504) This commit adds some changes to the way the AST for the source is built. The `analyze.go` program now ignores every `vendor`, `.git` and `testdata` folder. This improves performance, since `vendor` and `.git` are usually large folders (#504). By ignoring `testdata`, we mimick the behaviour of `go build` and avoid failing the parsing because of invalid Go code inside of `testdata` (#503) * [now-go] Don't ignore `.git` in analyze (#506) If the user wants to ignore `.git`, he should put it into `.nowignore`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.