Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix update message #5051

Merged
merged 2 commits into from
Aug 17, 2020
Merged

[cli] Fix update message #5051

merged 2 commits into from
Aug 17, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 17, 2020

The update message was sometimes printed when there was no update.

This PR fixes the update check to ensure the that it is only printed when the latest version differs from the current version.

image

@styfle
Copy link
Member Author

styfle commented Aug 17, 2020

@TooTallNate What do you think about dropping update-notifier (over 1 MB and 70+ transitive deps) in favor of running this instead in the background:

npm view vercel dist-tags --json

@styfle styfle merged commit df86a6d into master Aug 17, 2020
@styfle styfle deleted the ch8283/update-msg branch August 17, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants