[next] Add tests for optional catch-all fallback true page params #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 5, 2020
This makes sure to normalize the params for optional catch-all routes on Vercel since for `fallback: true` pages the `[[...paramName]]` value will be provided for the undefined/root param which needs to be normalized. Tests have been added in vercel/vercel#5247 and were manually tested with the changes in this PR with https://github.com/ijjk/next-update-loader Fixes: #17220 x-ref: vercel/vercel#5247
Timer
previously approved these changes
Jan 4, 2021
styfle
reviewed
Jan 4, 2021
packages/now-next/test/fixtures/00-optional-fallback-revalidate/now.json
Outdated
Show resolved
Hide resolved
styfle
approved these changes
Jan 5, 2021
Timer
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for optional catch-all
fallback: truepages to ensure the params are normalized correctly. These should be failing initially until the PR with the normalizing fix in Next.js is released to canary.x-ref: vercel/next.js#17220