Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Fix dev routing when using routes with a frontend framework #5253

Merged
merged 3 commits into from
Oct 2, 2020
Merged

[cli] Fix dev routing when using routes with a frontend framework #5253

merged 3 commits into from
Oct 2, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 2, 2020 •
edited

There was a regression when introducing multiple phases such as hit and miss which caused routes to stop working because the transition from null phase to the filesystem phase resets any dest rewrites.

The workaround is to detect when we don't have a filesystem phase and exit early.

@styfle styfle marked this pull request as ready for review October 2, 2020 22:40
@styfle styfle changed the title [cli] Fix dev routing [cli] Fix dev routing when using routes with a frontend framework Oct 2, 2020
@styfle styfle requested a review from dav-is October 2, 2020 22:44
@kodiakhq kodiakhq bot merged commit 16e101d into master Oct 2, 2020
@kodiakhq kodiakhq bot deleted the ch11192/dev-next-routes branch October 2, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@dav-is dav-is dav-is approved these changes

@AndyBitz AndyBitz Awaiting requested review from AndyBitz

Assignees
No one assigned
Labels
area: cli area: dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@styfle @TooTallNate @dav-is