Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Rename "Provided by system" to "Reference ..." #5415

Merged
merged 4 commits into from
Nov 12, 2020
Merged

[cli] Rename "Provided by system" to "Reference ..." #5415

merged 4 commits into from
Nov 12, 2020

Conversation

lucleray
Copy link
Member

@lucleray lucleray commented Nov 12, 2020 •
edited

Ref: https://app.clubhouse.io/vercel/story/14668

Rename Provided by system to Reference to System Environment Variable in preparation for automatically exposing system env variables (see ref).

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@lucleray lucleray marked this pull request as draft November 12, 2020 17:48
@lucleray lucleray changed the title [cli] Rename "Provided by system" to "Reference ... [cli] Rename "Provided by system" to "Reference ..." Nov 12, 2020
styfle
styfle approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update the test too

@lucleray lucleray marked this pull request as ready for review November 12, 2020 21:05
@lucleray lucleray merged commit 422f055 into master Nov 12, 2020
@lucleray lucleray deleted the rename-provided-by-system branch November 12, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucleray @styfle