-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Add tests to compare dev/prd image optimization #5428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@styfle does vc dev
return last-modified
? That's something that people have asked about, imgix returns it and we simply forward it
@juancampa No it does not. The |
Got it, that's an inconsistency that we might want to fix later |
@juancampa I think the inconsistency is inherent to the fact that Next.js is optimizing the image itself (thus has the Etag readily at its disposal) verses on Vercel where we proxy Imgix. I don't see the need to be consistent here. |
I could see users being confused by etags appearing in their |
"version": 2, | ||
"build": { | ||
"env": { | ||
"FORCE_BUILDER_TAG": "canary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not necessary but it will help us catch differences in @vercel/next
canary before they go to stable
Add E2E test for to test image optimization against
vc dev
as well as a prod deployment.馃搵 Checklist
Tests
yarn test-unit
Code Review