Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Expose system envs when autoExposeSystemEnvs is enabled on vc dev #5434

Merged
merged 10 commits into from
Nov 17, 2020
Merged

[cli] Expose system envs when autoExposeSystemEnvs is enabled on vc dev #5434

merged 10 commits into from
Nov 17, 2020

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Nov 17, 2020 •
edited by styfle

Ref: https://app.clubhouse.io/vercel/story/15112

We added a property called autoExposeSystemEnvs to projects. If that property is true, we automatically expose system env variables such as VERCEL=1, VERCEL_ENV=<production | preview>, ... to the runtime and build time.

This PR makes sure we mirror this behavior when running vc dev locally.

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@nkzawa nkzawa requested a review from lucleray November 17, 2020 16:38
@lucleray lucleray marked this pull request as ready for review November 17, 2020 20:47
@lucleray lucleray added area: cli semver: patch PR contains bug fixes labels Nov 17, 2020
@lucleray lucleray marked this pull request as draft November 17, 2020 21:11
@lucleray lucleray marked this pull request as ready for review November 17, 2020 21:26
@kodiakhq kodiakhq bot merged commit 659c4d6 into master Nov 17, 2020
@kodiakhq kodiakhq bot deleted the now-cli-auto-expose-system-env branch November 17, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@styfle styfle styfle approved these changes

@lucleray lucleray Awaiting requested review from lucleray

@AndyBitz AndyBitz Awaiting requested review from AndyBitz

Assignees
No one assigned
Labels
area: cli semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nkzawa @TooTallNate @styfle @lucleray