Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add vercel bisect command #5778

Merged
merged 5 commits into from
Feb 1, 2022
Merged

[cli] Add vercel bisect command #5778

merged 5 commits into from
Feb 1, 2022

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Feb 3, 2021

This PR adds a new vercel bisect command which is inspired by git bisect. This command takes two deployment URLs as its input (one "bad" deployment that exhibits a bug, and one "good" deployment where the bug does not occur) and steps through the deployments using a binary search. The command is useful for finding a deployment (and commit if the project is connected to a Git repo) where a bug has been introduced.

Screen Shot 2022-01-26 at 12 46 29 PM

@TooTallNate TooTallNate changed the title [cli] WIP Add vercel bisect command [cli] Add vercel bisect command Feb 5, 2021
@TooTallNate TooTallNate added the semver: minor PR contains new features label Feb 10, 2021
@kodiakhq kodiakhq bot removed the semver: minor PR contains new features label Feb 25, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 25, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the ['semver-major', 'semver-minor', 'semver-patch'] label.

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #5778 (e786313) into main (a1787c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5778   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files         134      134           
  Lines        5381     5381           
  Branches     1350     1350           
=======================================
  Hits         2661     2661           
  Misses       2712     2712           
  Partials        8        8           
Impacted Files Coverage Δ
packages/cli/src/commands/deploy/args.ts 100.00% <ø> (ø)
packages/cli/src/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1787c7...e786313. Read the comment docs.

if (exitCode === 0) {
color = chalk.green;
action = 'good';
} else if (exitCode === 125) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to document this exit code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Co-authored-by: Steven <steven@ceriously.com>
@@ -133,6 +133,13 @@ export type Deployment = {
created: number;
createdAt: number;
creator: { uid: string; username: string };
target: string | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target: string | null;
target: string | null | undefined;

@TooTallNate TooTallNate added the semver: minor PR contains new features label Feb 1, 2022
@kodiakhq kodiakhq bot merged commit 2402db9 into main Feb 1, 2022
@kodiakhq kodiakhq bot deleted the bisect-effect branch February 1, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: minor PR contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants