Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Refactor vc switch command #6257

Merged
merged 10 commits into from May 20, 2021
Merged

[cli] Refactor vc switch command #6257

merged 10 commits into from May 20, 2021

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented May 19, 2021 •
edited

Refactors the vc switch command to more closely match how the team picker works on the Vercel dashboard:

  • Converts to TypeScript
  • Adds separator between user scope and team scopes
  • Sorts teams by name
  • No longer places the current scope at the top of the list (but the current scope is still selected by default)

Screen Shot 2021-05-20 at 11 18 12 AM

@TooTallNate TooTallNate marked this pull request as ready for review May 20, 2021 16:48
AndyBitz
AndyBitz approved these changes May 20, 2021
View reviewed changes
packages/cli/src/commands/teams/switch.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/teams/switch.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/teams/switch.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/teams/switch.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/teams/switch.ts Outdated Show resolved Hide resolved
@TooTallNate @AndyBitz
Apply suggestions from code review
5653dd8 
Co-authored-by: Andy <AndyBitz@users.noreply.github.com>
@TooTallNate TooTallNate merged commit 7b509ae into main May 20, 2021
@TooTallNate TooTallNate deleted the update/vc-switch-rewrite branch May 20, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyBitz AndyBitz AndyBitz approved these changes

@lucleray lucleray Awaiting requested review from lucleray

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TooTallNate @AndyBitz