Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-utils] check to see that the node version is less then 16 befo… #6553

Merged
merged 5 commits into from
Aug 7, 2021

Conversation

ktcarter
Copy link
Contributor

@ktcarter ktcarter commented Aug 4, 2021

Related Issues

Check the project's nodeVersion setting for when we release Node 16 and later

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@styfle
Copy link
Member

styfle commented Aug 4, 2021

Looks like tests are failing

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #6553 (8839321) into main (e6fb2ff) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6553      +/-   ##
==========================================
+ Coverage   13.18%   13.39%   +0.21%     
==========================================
  Files         272      272              
  Lines        9929     9929              
  Branches     1566     1566              
==========================================
+ Hits         1309     1330      +21     
+ Misses       8529     8508      -21     
  Partials       91       91              
Impacted Files Coverage Δ
src/util/dev/server.ts 53.75% <0.00%> (+0.86%) ⬆️
src/util/dev/builder-cache.ts 75.90% <0.00%> (+8.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fb2ff...8839321. Read the comment docs.

@ktcarter ktcarter self-assigned this Aug 6, 2021
@TooTallNate TooTallNate changed the title [build utils] check to see that the node version is less then 16 befo… [build-utils] check to see that the node version is less then 16 befo… Aug 6, 2021
@TooTallNate TooTallNate added area: build-utils semver: minor PR contains new features labels Aug 6, 2021
@kodiakhq kodiakhq bot merged commit 18bec98 into main Aug 7, 2021
@kodiakhq kodiakhq bot deleted the add-nodeversion-npm7 branch August 7, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build-utils semver: minor PR contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants