-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-utils] check to see that the node version is less then 16 befo… #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re installing npm 7
styfle
reviewed
Aug 4, 2021
styfle
approved these changes
Aug 4, 2021
Looks like tests are failing |
Codecov Report
@@ Coverage Diff @@
## main #6553 +/- ##
==========================================
+ Coverage 13.18% 13.39% +0.21%
==========================================
Files 272 272
Lines 9929 9929
Branches 1566 1566
==========================================
+ Hits 1309 1330 +21
+ Misses 8529 8508 -21
Partials 91 91
Continue to review full report at Codecov.
|
styfle
approved these changes
Aug 5, 2021
TooTallNate
changed the title
[build utils] check to see that the node version is less then 16 befo…
[build-utils] check to see that the node version is less then 16 befo…
Aug 6, 2021
TooTallNate
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Check the project's nodeVersion setting for when we release Node 16 and later
📋 Checklist
Tests
yarn test-unit
Code Review