Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix in-flight re-login when there are no existing credentials #6565

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

TooTallNate
Copy link
Member

This logic broke because the doLoginPrompt() return value changed in #6415 (we really need to convert this src/index.js file to TypeScript).

@TooTallNate TooTallNate added area: cli triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked semver: patch PR contains bug fixes labels Aug 7, 2021
@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #6565 (c80550e) into main (a60b1b2) will increase coverage by 0.82%.
The diff coverage is n/a.

❗ Current head c80550e differs from pull request most recent head ff6f09e. Consider uploading reports for the commit ff6f09e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6565      +/-   ##
==========================================
+ Coverage   12.33%   13.16%   +0.82%     
==========================================
  Files         272      272              
  Lines        9807     9924     +117     
  Branches     1627     1567      -60     
==========================================
+ Hits         1210     1306      +96     
- Misses       8497     8529      +32     
+ Partials      100       89      -11     
Impacted Files Coverage Δ
src/index.js 0.00% <0.00%> (ø)
src/util/dev/builder-cache.ts 67.46% <0.00%> (+2.99%) ⬆️
src/util/metrics.ts 57.69% <0.00%> (+3.14%) ⬆️
src/util/dev/server.ts 52.89% <0.00%> (+3.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60b1b2...ff6f09e. Read the comment docs.

@TooTallNate TooTallNate merged commit d2e82fd into main Aug 8, 2021
@TooTallNate TooTallNate deleted the fix/cli-in-flight-login branch August 8, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: patch PR contains bug fixes triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants