Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix GET /api/examples/list output #6574

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

TooTallNate
Copy link
Member

A regression from #6554 caused the return value to contain a nested object with a name property for the name key of the response in the list.

A regression from #6554 caused the return value to contain a nested
object with a `name` property for the `name` key of the response in the
list.
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #6574 (2bbe20b) into main (2756d1e) will increase coverage by 0.86%.
The diff coverage is n/a.

❗ Current head 2bbe20b differs from pull request most recent head 01f6b85. Consider uploading reports for the commit 01f6b85 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6574      +/-   ##
==========================================
+ Coverage   12.31%   13.18%   +0.86%     
==========================================
  Files         272      272              
  Lines        9802     9931     +129     
  Branches     1628     1566      -62     
==========================================
+ Hits         1207     1309     +102     
- Misses       8497     8531      +34     
+ Partials       98       91       -7     
Impacted Files Coverage Δ
src/util/metrics.ts 54.54% <0.00%> (-3.15%) ⬇️
src/util/dev/builder-cache.ts 67.46% <0.00%> (+2.99%) ⬆️
src/util/dev/server.ts 52.89% <0.00%> (+3.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2756d1e...01f6b85. Read the comment docs.

@styfle
Copy link
Member

styfle commented Aug 10, 2021

Nice catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants