Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Remove withSpinner() helper #6576

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

TooTallNate
Copy link
Member

It's not really necessary and doesn't use the common Output instance.

It's not really necessary and doesn't use the common `Output` instance.
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #6576 (9ccf6f8) into main (f1009a8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6576      +/-   ##
==========================================
+ Coverage   12.31%   12.33%   +0.01%     
==========================================
  Files         272      271       -1     
  Lines        9802     9788      -14     
  Branches     1628     1627       -1     
==========================================
  Hits         1207     1207              
+ Misses       8497     8483      -14     
  Partials       98       98              
Impacted Files Coverage Δ
src/commands/env/rm.ts 0.00% <0.00%> (ø)
src/commands/env/add.ts 0.00% <0.00%> (ø)
src/commands/env/pull.ts 0.00% <0.00%> (ø)
src/commands/domains/move.ts 0.00% <0.00%> (ø)
src/commands/domains/transfer-in.ts 0.00% <0.00%> (ø)
src/util/with-spinner.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1009a8...9ccf6f8. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@styfle styfle added area: cli semver: patch PR contains bug fixes labels Aug 10, 2021
@TooTallNate TooTallNate merged commit 52a89fd into main Aug 10, 2021
@TooTallNate TooTallNate deleted the remove/cli-with-spinner branch August 10, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants