Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Attempt to fix the "lambda-with-3-second-timeout" E2E test #6579

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

TooTallNate
Copy link
Member

This test has been failing a lot recently, with the 2 second timeout case receiving a 504 status code. My theory is that the cold-start time is making the 3 second timeout be hit, even though the sleep time is for 2 seconds. So test the two paths serially instead, and test the 2 second timeout last. This way, we know that the lambda has is hot.

Example: https://github.com/vercel/vercel/runs/3296671662

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #6579 (0d310be) into main (3616bdf) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 0d310be differs from pull request most recent head ba0fb75. Consider uploading reports for the commit ba0fb75 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6579      +/-   ##
==========================================
+ Coverage   12.33%   12.50%   +0.17%     
==========================================
  Files         271      271              
  Lines        9788     9788              
  Branches     1627     1627              
==========================================
+ Hits         1207     1224      +17     
+ Misses       8483     8463      -20     
- Partials       98      101       +3     
Impacted Files Coverage Δ
src/util/dev/server.ts 49.78% <0.00%> (+0.85%) ⬆️
src/util/dev/builder-cache.ts 71.71% <0.00%> (+7.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3616bdf...ba0fb75. Read the comment docs.

@TooTallNate TooTallNate force-pushed the fix/cli-test-lambda-with-3-second-timeout branch from cae5f4d to ba0fb75 Compare August 11, 2021 07:17
@TooTallNate TooTallNate marked this pull request as ready for review August 11, 2021 07:50
@TooTallNate TooTallNate merged commit 9fb254e into main Aug 11, 2021
@TooTallNate TooTallNate deleted the fix/cli-test-lambda-with-3-second-timeout branch August 11, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant