Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Refactor vc teams to TypeScript #6610

Merged
merged 7 commits into from
Aug 24, 2021
Merged

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Aug 19, 2021

Refactors the four vc teams related subcommands to TypeScript, and removes the NowTeams class that subclassed from the legacy Now class. All for a net reduction of ~50 LOC!

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #6610 (f36ecbe) into main (578fe8a) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6610      +/-   ##
==========================================
+ Coverage   12.46%   12.66%   +0.19%     
==========================================
  Files         263      265       +2     
  Lines        9691     9651      -40     
  Branches     1693     1711      +18     
==========================================
+ Hits         1208     1222      +14     
+ Misses       8384     8331      -53     
+ Partials       99       98       -1     
Impacted Files Coverage Δ
src/index.js 0.00% <0.00%> (ø)
src/util/output/chars.ts 0.00% <0.00%> (ø)
src/commands/teams/index.ts 0.00% <0.00%> (ø)
src/commands/teams/list.js
src/util/teams.js
src/commands/teams/invite.js
src/commands/teams/add.js
src/util/get-team-by-id.ts
src/util/get-teams.ts
src/util/teams/invite-user-to-team.ts 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578fe8a...f36ecbe. Read the comment docs.

@TooTallNate TooTallNate marked this pull request as ready for review August 21, 2021 20:49
@TooTallNate TooTallNate added area: cli semver: minor PR contains new features labels Aug 21, 2021
@TooTallNate TooTallNate changed the title [WIP] Refactor vc teams to TypeScript [cli] Refactor vc teams to TypeScript Aug 21, 2021
@TooTallNate TooTallNate merged commit ee9a8a0 into main Aug 24, 2021
@TooTallNate TooTallNate deleted the update/cli-teams-typescript branch August 24, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: minor PR contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants