Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Refactor legacy Now client to TypeScript #6650

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Aug 31, 2021

Refactors one of the last remaining big JS files to TypeScript. I'd prefer to eliminate this file completely, but it's still very tightly coupled to the deployment process, so figured it was easier to just bite the bullet and refactor it to TS. This is necessary because the Jest unit tests don't like the .js files that use import (I'm sure there's a way to configure babel within Jest to support es6 module syntax, but since we want the code to be TS anyways, this is more killing two birds with one stone).

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #6650 (40dc088) into main (273718e) will not change coverage.
The diff coverage is 25.00%.

❗ Current head 40dc088 differs from pull request most recent head 6f66cba. Consider uploading reports for the commit 6f66cba to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6650   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files          85       85           
  Lines        3592     3592           
  Branches      841      841           
=======================================
  Hits         1975     1975           
  Misses       1611     1611           
  Partials        6        6           
Impacted Files Coverage Δ
packages/cli/src/util/config/files.ts 30.43% <0.00%> (ø)
packages/cli/src/util/client.ts 70.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273718e...6f66cba. Read the comment docs.

@TooTallNate TooTallNate added area: cli semver: minor PR contains new features labels Aug 31, 2021
@TooTallNate TooTallNate merged commit f18bca9 into main Aug 31, 2021
@TooTallNate TooTallNate deleted the update/cli-refactor-now-typescript branch August 31, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: minor PR contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants