[all] Bump ncc to 0.31.1 #6700
[all] Bump ncc to 0.31.1 #6700
Conversation
styfle
added
area: build-utils
area: go
area: node
area: python
area: ruby
area: cli
semver: patch
Codecov Report
@@ Coverage Diff @@
## main #6700 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 85 85
Lines 3592 3592
Branches 841 841
=======================================
Hits 1975 1975
Misses 1613 1613
Partials 4 4 Continue to review full report at Codecov.
|
| return 1; | ||
| } | ||
|
|
||
| if (func.default) { |
There was a problem hiding this comment.
I believe this is always going to be true.
There was a problem hiding this comment.
Some of the commands are TS and some are JS (notable secrets.js) so this might be different
| const metric = metrics(); | ||
| let exitCode; | ||
| const eventCategory = 'Exit Code'; | ||
|
|
||
| try { | ||
| const start = Date.now(); | ||
| const full = require(`./commands/${targetCommand}`).default; | ||
| exitCode = await full(client); | ||
| let func: any; |
There was a problem hiding this comment.
| let func: any; | |
| let func: (c: Client) => Promise<number>; |
There was a problem hiding this comment.
This was failing for me which is why I left it as any.
I'll try again in another PR and see if we can get this more strict.
Another option is to move the imports to the top because they're already bundled into a single file via ncc.
https://github.com/vercel/ncc/releases/tag/0.31.0
https://github.com/vercel/ncc/releases/tag/0.31.1