-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'VITE_' prefix to SvelteKit framework #6821
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6821 +/- ##
=======================================
Coverage 49.17% 49.17%
=======================================
Files 135 135
Lines 5426 5426
Branches 1358 1358
=======================================
Hits 2668 2668
Misses 2745 2745
Partials 13 13 Continue to review full report at Codecov.
|
You might want to check with @styfle, I believe changing the env var preset is considered a breaking change here. Did SvelteKit change this under the hood? |
Is it the reason I cannot get SVELTEKIT_VERCEL_URL on vercel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @domeccleston! |
This should be updated to |
We actually don't want a prefix here, because it would cause the values to be available via In particular, adding them to public env will mean they're included in every rendered HTML page (because that's how |
馃搵 Checklist
Since SvelteKit uses Vite under the hood, it needs the _VITE environment variable prefix. This adds it.
Example which reproduces the Svelte Kit example with undefined environment variables:
Tests
Currently I get an error when trying to run the tests:
Module ts-jest in the transform option was not found.
yarn test-unit
Code Review