[cli] Add outputBuffer getter and mutable isTTY for tests
#6827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes originally from #6652, but pulled out to be merged separately. `outputBuffer` is a simpler way of asserting tests against the CLI output instead of working directly withe Jest mock function. `output.isTTY` is also now mutable, so that we can write tests for both cases when the output is different based on TTY-ness (for example, see the updated `vc whoami` tests in this PR).
Codecov Report
@@ Coverage Diff @@
## main #6827 +/- ##
==========================================
+ Coverage 54.98% 55.03% +0.05%
==========================================
Files 85 85
Lines 3592 3594 +2
Branches 829 830 +1
==========================================
+ Hits 1975 1978 +3
+ Misses 1611 1610 -1
Partials 6 6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes related to CLI tests arer originally from #6652, but pulled out to be merged separately.
outputBufferis a simpler way of asserting tests against the CLI output instead of working directly withe Jest mock function.output.isTTYis also now mutable, so that we can write tests for both cases when the output is different based on TTY-ness (for example, see the updatedvc whoamitests in this PR).