Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Don't pass teamId query param to /verify token endpoint #6841

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

TooTallNate
Copy link
Member

Fixes an issue where the token would not be properly upgraded while a Team scope was currently active, causing a new auth token to be issued and lose the previous access scope(s).

Fixes an issue where the token would not be properly upgraded while
a Team scope was currently active, causing a new auth token to be issued
and lose the previous access scope(s).
@TooTallNate TooTallNate added area: cli triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked semver: patch PR contains bug fixes labels Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #6841 (a67383c) into main (32e935d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6841   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files          85       85           
  Lines        3594     3594           
  Branches      830      830           
=======================================
  Hits         1978     1978           
  Misses       1610     1610           
  Partials        6        6           
Impacted Files Coverage Δ
packages/cli/src/util/login/verify.ts 23.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e935d...a67383c. Read the comment docs.

@TooTallNate TooTallNate merged commit e01a1ce into main Oct 13, 2021
@TooTallNate TooTallNate deleted the fix/cli-team-token-upgrade branch October 13, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: patch PR contains bug fixes triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants