[cli] Add CLI login unit test #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
commented
Oct 19, 2021
| @@ -100,7 +100,7 @@ export default class Client extends EventEmitter { | |||
| let body; | |||
| if (isJSONObject(opts.body)) { | |||
| body = JSON.stringify(opts.body); | |||
| headers.set('content-type', 'application/json; charset=utf8'); | |||
| headers.set('content-type', 'application/json; charset=utf-8'); | |||
There was a problem hiding this comment.
Needed because express' body-parser is strict about this (which we use for the API test mocks - this is the first test that does a POST apparently).
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
AndyBitz
approved these changes
Oct 19, 2021
styfle
approved these changes
Oct 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #6866 +/- ##
==========================================
+ Coverage 49.26% 50.71% +1.45%
==========================================
Files 126 126
Lines 4882 4886 +4
Branches 1166 1166
==========================================
+ Hits 2405 2478 +73
+ Misses 2466 2398 -68
+ Partials 11 10 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has just been sitting in my working tree for a while, might as well push it up.