Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[routing-utils] Add missing fields #6872

Merged
merged 5 commits into from
Oct 21, 2021
Merged

[routing-utils] Add missing fields #6872

merged 5 commits into from
Oct 21, 2021

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Oct 21, 2021

Essentially its the negate version of has.

@Kikobeats Kikobeats changed the title chore: add missing fields chore: add missing fields Oct 21, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just renaming the TS type? What's the purpose?

Copy link
Contributor

@dav-is dav-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

@javivelasco
Copy link
Member

Is this just renaming the TS type? What's the purpose?

It's adding missing @styfle

@styfle
Copy link
Member

styfle commented Oct 21, 2021

Looks like missing was just added in the new commit e09bba7

CI is failing because HasField is used in other packages in this repo

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #6872 (47953b6) into main (c35c054) will not change coverage.
The diff coverage is n/a.

❗ Current head 47953b6 differs from pull request most recent head f94a9d9. Consider uploading reports for the commit f94a9d9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6872   +/-   ##
=======================================
  Coverage   50.71%   50.71%           
=======================================
  Files         126      126           
  Lines        4886     4886           
  Branches     1166     1166           
=======================================
  Hits         2478     2478           
  Misses       2398     2398           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35c054...f94a9d9. Read the comment docs.

@styfle styfle changed the title chore: add missing fields [routing-utils] Add missing fields Oct 21, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added to the schema and also needs a test

export const hasSchema = {

@styfle styfle added the semver: patch PR contains bug fixes label Oct 21, 2021
@ijjk ijjk merged commit 981a76f into main Oct 21, 2021
@ijjk ijjk deleted the missing-1 branch October 21, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants