-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[routing-utils] Add missing
fields
#6872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just renaming the TS type? What's the purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks
It's adding |
Looks like CI is failing because HasField is used in other packages in this repo |
Codecov Report
@@ Coverage Diff @@
## main #6872 +/- ##
=======================================
Coverage 50.71% 50.71%
=======================================
Files 126 126
Lines 4886 4886
Branches 1166 1166
=======================================
Hits 2478 2478
Misses 2398 2398
Partials 10 10 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be added to the schema and also needs a test
export const hasSchema = { |
Essentially its the negate version of
has
.