Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix resolving of config paths #6969

Merged
merged 2 commits into from
Nov 9, 2021
Merged

[cli] Fix resolving of config paths #6969

merged 2 commits into from
Nov 9, 2021

Conversation

msimulcik
Copy link
Contributor

This PR fixes functions for resolving local and global config paths. The issue was that --local-config resp. --global-config arguments were silently ignored when other than common args were also used (e.g. --confirm). It caused that CLI integration tests were failing locally.

Related Issues

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks! 馃帀

@styfle styfle added area: tests semver: patch PR contains bug fixes labels Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #6969 (32a2873) into main (ed1dacd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6969      +/-   ##
==========================================
+ Coverage   51.53%   51.56%   +0.02%     
==========================================
  Files         128      128              
  Lines        4969     4967       -2     
  Branches     1167     1167              
==========================================
  Hits         2561     2561              
+ Misses       2402     2400       -2     
  Partials        6        6              
Impacted Files Coverage 螖
packages/cli/src/util/config/global-path.ts 100.00% <100.00%> (+5.00%) 猬嗭笍
packages/cli/src/util/config/local-path.ts 76.19% <100.00%> (+3.46%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ed1dacd...32a2873. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants