Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frameworks][examples] Add solidstart template #6984

Merged
merged 8 commits into from
Dec 13, 2021
Merged

Conversation

ryansolid
Copy link
Contributor

@ryansolid ryansolid commented Nov 12, 2021

This PR adds support for Solid framework with a default Solid client rendered template and a SolidStart SSR template and corresponding example projects.

I think I've put most things together, but a lot of copy and paste. Let me know if I'm missing anything.

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@styfle styfle changed the title add solid/solidstart templates [frameworks][examples] Add solid/solidstart templates Nov 17, 2021
examples/solid/README.md Outdated Show resolved Hide resolved
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a yarn.lock file committed to the example as well

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the "Solid" example since it doesn't have a framework preset anymore.

We just need the SolidStart example 👍

@ryansolid
Copy link
Contributor Author

Let's also remove the "Solid" example since it doesn't have a framework preset anymore.
We just need the SolidStart example 👍

Sure. It does feel odd to me that the much more common(CSR) and the currently recommended way to use Solid wouldn't be part of this (SolidStart is still really new and only does SSR/SSG-based apps). But from entries perspective, I can see it making sense.

@ryansolid ryansolid changed the title [frameworks][examples] Add solid/solidstart templates [frameworks][examples] Add solidstart template Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants