-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frameworks][examples] Add solidstart template #6984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a yarn.lock
file committed to the example as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also remove the "Solid" example since it doesn't have a framework preset anymore.
We just need the SolidStart example 👍
Sure. It does feel odd to me that the much more common(CSR) and the currently recommended way to use Solid wouldn't be part of this (SolidStart is still really new and only does SSR/SSG-based apps). But from entries perspective, I can see it making sense. |
This PR adds support for Solid framework with a default Solid client rendered template and a SolidStart SSR template and corresponding example projects.
I think I've put most things together, but a lot of copy and paste. Let me know if I'm missing anything.
Tests
yarn test-unit
Code Review