Don't throw Domain not found when trying to now alias to a new domain
#702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlliV
approved these changes
Jun 30, 2017
TooTallNate
reviewed
Jun 30, 2017
lib/alias.js
Outdated
| throw err | ||
| } | ||
| } | ||
| const domainInfo = _domainInfo && !_domainInfo.error |
There was a problem hiding this comment.
Shouldn't we do something with _domainInfo.error like relay it to the user?
There was a problem hiding this comment.
@TooTallNate we handle that somewhere – the user will see proper errors:
now alias gifs-zjduxbfjas.now.sh vigour.io
> vigour.io is a custom domain.
> Verifying the DNS settings for vigour.io (see https://zeit.world for help)
> Error! You don't have access to "vigour.io"
|
Will fix the prettier stuff and fix it ASAP 👍 |
|
@matheuss status? |
TooTallNate
pushed a commit
that referenced
this pull request
Aug 23, 2019
Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. - [Release notes](https://github.com/npm/fstream/releases) - [Commits](npm/fstream@v1.0.11...v1.0.12) Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After