Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frameworks][cli] Consolidate buildCommand and devCommand #7032

Merged
merged 5 commits into from
Nov 20, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 19, 2021

This PR avoids duplication and and makes front display the correct value on "Override".

This also fixes a bug with vercel build to retrieve and display the correct Build Command when no Override is enabled and no package.json is found. This fixes hugo builds.

@styfle styfle changed the title [frameworks] Consolidate buildCommand and devCommand [frameworks][cli] Consolidate buildCommand and devCommand Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #7032 (8a7491b) into main (a72549a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7032   +/-   ##
=======================================
  Coverage   51.48%   51.48%           
=======================================
  Files         128      128           
  Lines        4976     4976           
  Branches     1168     1168           
=======================================
  Hits         2562     2562           
  Misses       2407     2407           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72549a...8a7491b. Read the comment docs.

@styfle styfle merged commit edd9bb5 into main Nov 20, 2021
@styfle styfle deleted the frameworks-consolidate branch November 20, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants