Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Show error when Ruby 2.5.x detected #7126

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Dec 3, 2021

This will show a better error message when Ruby 2.5.x is detected and explain how to upgrade.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7126 (ddfe596) into main (5efd3b9) will not change coverage.
The diff coverage is n/a.

❗ Current head ddfe596 differs from pull request most recent head 2f18522. Consider uploading reports for the commit 2f18522 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7126   +/-   ##
=======================================
  Coverage   51.49%   51.49%           
=======================================
  Files         128      128           
  Lines        4979     4979           
  Branches     1212     1212           
=======================================
  Hits         2564     2564           
  Misses       2403     2403           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efd3b9...2f18522. Read the comment docs.

@styfle styfle marked this pull request as ready for review December 3, 2021 18:16
@styfle styfle requested a review from AndyBitz December 3, 2021 18:17
@styfle styfle added area: ruby semver: minor PR contains new features semver: patch PR contains bug fixes and removed semver: minor PR contains new features labels Dec 3, 2021
@styfle styfle merged commit b94337d into main Dec 3, 2021
@styfle styfle deleted the ruby25-discontinue-eol branch December 3, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ruby semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants