Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Speed up GH publish skip #7175

Merged
merged 2 commits into from
Dec 10, 2021
Merged

[ci] Speed up GH publish skip #7175

merged 2 commits into from
Dec 10, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Dec 10, 2021

This is following a similar pattern to Next.js workflows so that the publish step is skipped and reduces the time it takes GH Actions to run since we don't need to build to know that it should be skipped.

echo "::set-output name=IS_RELEASE::false"
else
echo "::set-output name=IS_RELEASE::true"
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is an excerpt from the existing publish script here:

vercel/utils/publish.sh

Lines 18 to 23 in ecb4481

tag="$(git describe --tags --exact-match 2> /dev/null || :)"
if [ -z "$tag" ]; then
echo "Not a tagged commit, skipping publish"
exit 0
fi

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #7175 (33abc0e) into main (ecb4481) will not change coverage.
The diff coverage is n/a.

❗ Current head 33abc0e differs from pull request most recent head c44f77c. Consider uploading reports for the commit c44f77c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7175   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files         135      135           
  Lines        5426     5426           
  Branches     1358     1358           
=======================================
  Hits         2668     2668           
  Misses       2745     2745           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb4481...c44f77c. Read the comment docs.

@kodiakhq kodiakhq bot merged commit d563b96 into main Dec 10, 2021
@kodiakhq kodiakhq bot deleted the skip-publish-if-not-tagged branch December 10, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants