Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Major: remove "now" prop from package.json #7186

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Dec 13, 2021

Its not clear if this feature was ever documented, but we should consider this semver major to remove it.

Apparently, you could use a "now" prop in package.json instead of a separate now.json or vercel.json file.

This PR also removes a @ts-ignore in favor of handling a case when package.json fails to parse.

@styfle styfle added area: cli semver: major PR contains breaking changes labels Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #7186 (1daa3cb) into main (ca433a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7186   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files         135      135           
  Lines        5426     5426           
  Branches     1358     1358           
=======================================
  Hits         2668     2668           
  Misses       2745     2745           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca433a4...1daa3cb. Read the comment docs.

@styfle styfle merged commit 0505f4e into main Dec 14, 2021
@styfle styfle deleted the semver-major-remove-packagejson-now-prop branch December 14, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: major PR contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants