Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Update Nuxt template for Nuxt 3 #7298

Merged
merged 1 commit into from
Jan 10, 2022
Merged

[examples] Update Nuxt template for Nuxt 3 #7298

merged 1 commit into from
Jan 10, 2022

Conversation

leerob
Copy link
Member

@leerob leerob commented Jan 10, 2022

@leerob leerob requested a review from mcsdevv as a code owner January 10, 2022 19:52
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #7298 (ef95f95) into main (bae26cc) will not change coverage.
The diff coverage is n/a.

❗ Current head ef95f95 differs from pull request most recent head ec67ca1. Consider uploading reports for the commit ec67ca1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7298   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files         135      135           
  Lines        5426     5426           
  Branches     1358     1358           
=======================================
  Hits         2668     2668           
  Misses       2745     2745           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae26cc...ec67ca1. Read the comment docs.

leerob
leerob commented Jan 10, 2022
View reviewed changes
examples/nuxtjs/package.json
},
"devDependencies": {}
"devDependencies": {
"nuxt3": "latest"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Nuxt framework detection value is looking for nuxt3 already it seems, so we're good there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd485c1

styfle
styfle approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets also remember to deploy the new example if you haven't already 👍

@styfle styfle changed the title Update Nuxt template for Nuxt 3. [examples] Update Nuxt template for Nuxt 3 Jan 10, 2022
@styfle styfle added area: examples semver: patch PR contains bug fixes labels Jan 10, 2022
@leerob leerob merged commit c2a1987 into main Jan 10, 2022
@leerob leerob deleted the update-nuxt-template branch January 10, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@mcsdevv mcsdevv Awaiting requested review from mcsdevv

Assignees
No one assigned
Labels
area: examples semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leerob @styfle