Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SvelteKit example #7301

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Updated SvelteKit example #7301

merged 3 commits into from
Jan 18, 2022

Conversation

StephDietz
Copy link
Contributor

This PR updates the SvelteKit example to be the SvelteKit demo project using adapter-auto. It also updates the SvelteKit framework description.

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

… updated description of SvelteKit in frameworks.ts
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #7301 (f29c37e) into main (fc420c9) will not change coverage.
The diff coverage is n/a.

❗ Current head f29c37e differs from pull request most recent head 0059f11. Consider uploading reports for the commit 0059f11 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7301   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files         135      135           
  Lines        5426     5426           
  Branches     1358     1358           
=======================================
  Hits         2668     2668           
+ Misses       2750     2745    -5     
- Partials        8       13    +5     
Impacted Files Coverage Δ
packages/cli/src/util/index.ts 7.56% <0.00%> (ø)
packages/cli/src/util/dev/server.ts 59.42% <0.00%> (ø)
packages/cli/src/util/output/error.ts 31.25% <0.00%> (ø)
packages/cli/src/commands/deploy/index.ts 20.05% <0.00%> (ø)
packages/cli/src/util/deploy/process-deployment.ts 10.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc420c9...0059f11. Read the comment docs.

examples/sveltekit/README.md Outdated Show resolved Hide resolved
examples/sveltekit/README.md Outdated Show resolved Hide resolved
examples/sveltekit/README.md Outdated Show resolved Hide resolved
examples/sveltekit/README.md Outdated Show resolved Hide resolved
examples/sveltekit/package.json Outdated Show resolved Hide resolved
@leerob leerob merged commit bd88a55 into main Jan 18, 2022
@leerob leerob deleted the update-sveltekit-example branch January 18, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants