[build-utils] De-couple zip file creation from Lambda class
#7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the `Lambda` class itself just a reference of the files that are needed to produce a zip file, and adds a `createZip()` function that does the actual zip file creation. This will allow the zip file creation to be done in the Vercel build container instead of directly in the Builder itself. * Adds `files` property to `Lambda` class * Adds `createZip()` function to `Lambda` class * Deprecates the `createLambda()` function * Deprecates the `zipBuffer` property (only populated when `createLambda()` is used) * Removes the private `FILES_SYMBOL` symbol, since `files` is the same thing
Codecov Report
@@ Coverage Diff @@
## main #7417 +/- ##
=======================================
Coverage 49.45% 49.45%
=======================================
Files 134 134
Lines 5381 5381
Branches 1350 1350
=======================================
Hits 2661 2661
Misses 2707 2707
Partials 13 13
Continue to review full report at Codecov.
|
styfle
reviewed
Feb 10, 2022
styfle
reviewed
Feb 10, 2022
styfle
approved these changes
Feb 10, 2022
TooTallNate
changed the title
Lambda classLambda class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
Lambdaclass itself just a reference of the files that are needed to produce a zip file, and adds acreateZip()function that does the actual zip file creation. This will allow the zip file creation to be done in the Vercel build container instead of directly in the Builder itself.filesproperty toLambdaclasscreateZip()function toLambdaclasscreateLambda()function (new Lambda()should be used instead)zipBufferproperty (only populated whencreateLambda()is used)FILES_SYMBOLsymbol, sincefilesis the same thing