Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Add support for version 1.18 #7590

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Conversation

sorcererxw
Copy link
Contributor

@sorcererxw sorcererxw commented Mar 20, 2022

Related Issues

Go 1.18 has been released, but I find that I can't deploy my project on Vercel when go.mod has go 1.18 in it.

1.18 adds some very useful features. It would be very valuable for developers to have Vercel support 1.18.

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@sorcererxw sorcererxw marked this pull request as ready for review April 9, 2022 11:19
packages/go/go-helpers.ts Outdated Show resolved Hide resolved
@styfle styfle added area: go semver: patch PR contains bug fixes labels Apr 13, 2022
@sorcererxw sorcererxw requested a review from styfle April 14, 2022 04:55
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #7590 (f30b719) into main (9225246) will not change coverage.
The diff coverage is n/a.

❗ Current head f30b719 differs from pull request most recent head c3bc045. Consider uploading reports for the commit c3bc045 to get more accurate results

@@           Coverage Diff           @@
##             main    #7590   +/-   ##
=======================================
  Coverage   48.80%   48.80%           
=======================================
  Files         133      133           
  Lines        5331     5331           
  Branches     1338     1338           
=======================================
  Hits         2602     2602           
  Misses       2716     2716           
  Partials       13       13           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@styfle styfle merged commit d63e8d3 into vercel:main Apr 14, 2022
@sorcererxw sorcererxw deleted the feat/go-1.18 branch April 15, 2022 00:44
@sorcererxw
Copy link
Contributor Author

@styfle Will Vercel CI support go 1.18 after the next release of this package?

@styfle
Copy link
Member

styfle commented Apr 22, 2022

Yes in the next stable release. You can try it out today on the canary channel by adding an environment variable to your project: FORCE_RUNTIME_TAG=canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: go semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants