Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Remove un-needed use of secret for team as it mangles logs #7818

Merged
merged 1 commit into from
May 18, 2022
Merged

[tests] Remove un-needed use of secret for team as it mangles logs #7818

merged 1 commit into from
May 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 18, 2022

Related Issues

This removes the secret for turbo team as it filters anywhere vercel is printed in the logs and it doesn't really need to be secret.

x-ref: https://github.com/vercel/vercel/runs/6496893033?check_suite_focus=true

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk marked this pull request as ready for review May 18, 2022 21:02
@ijjk ijjk requested review from AndyBitz and styfle as code owners May 18, 2022 21:02
@ijjk ijjk requested a review from TooTallNate May 18, 2022 21:02
@ijjk ijjk added semver: patch PR contains bug fixes area: tests labels May 18, 2022
@kodiakhq kodiakhq bot merged commit 285f62c into main May 18, 2022
@kodiakhq kodiakhq bot deleted the update/turbo-team-env branch May 18, 2022 21:02
@styfle styfle changed the title Remove un-needed use of secret for team as it mangles logs [tests] Remove un-needed use of secret for team as it mangles logs May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@AndyBitz AndyBitz Awaiting requested review from AndyBitz

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

Assignees
No one assigned
Labels
area: tests semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle