-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fs-detectors] Exclude the middleware builder if it's a Next.js app #8239
Conversation
5d231c7
to
e86b49d
Compare
packages/fs-detectors/test/unit.builds-and-routes-detector.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should take into account the project creation date
(framework === undefined || createdAt < Date.parse('2020-03-01')) |
You might even use detectFrontBuilder()
instead
…ramework selected
I'm seeing failures in CI but it appears the same happen in some other PRs. Are they just flaky? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
While
maybeGetApiBuilder()
excludes the middleware builder, however, we need another check for the case whereprojectSettings.framework == null
.Related Issues
📋 Checklist
Tests
yarn test-unit
Code Review