Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fs-detectors] Exclude the middleware builder if it's a Next.js app #8239

Merged
merged 7 commits into from
Aug 1, 2022

Conversation

nuta
Copy link
Contributor

@nuta nuta commented Jul 25, 2022

While maybeGetApiBuilder() excludes the middleware builder, however, we need another check for the case where projectSettings.framework == null.

Related Issues

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should take into account the project creation date

(framework === undefined || createdAt < Date.parse('2020-03-01'))

You might even use detectFrontBuilder() instead

@nuta
Copy link
Contributor Author

nuta commented Jul 29, 2022

I'm seeing failures in CI but it appears the same happen in some other PRs. Are they just flaky?

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle added the semver: patch PR contains bug fixes label Aug 1, 2022
@styfle styfle merged commit 71b3ded into main Aug 1, 2022
@styfle styfle deleted the dont-run-node-builder-in-nextjs-with-middlewares branch August 1, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants