Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Remove un-necessary duplicate i18n route #8313

Merged
merged 3 commits into from Aug 4, 2022
Merged

[next] Remove un-necessary duplicate i18n route #8313

merged 3 commits into from Aug 4, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 4, 2022

Related Issues

While inspecting routes for a deployment with i18n I noticed we had an un-necessary duplicate route so this removes it as this also causes an additional un-necessary filesystem check when an output isn't matched.

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk added semver: patch PR contains bug fixes area: next labels Aug 4, 2022
@ijjk ijjk marked this pull request as ready for review August 4, 2022 01:53
@ijjk ijjk requested a review from TooTallNate as a code owner August 4, 2022 01:53
@ijjk ijjk requested a review from styfle August 4, 2022 01:53
@ijjk ijjk merged commit 6bfff3e into main Aug 4, 2022
@ijjk ijjk deleted the ijjk/remove-duplicate-route branch August 4, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

Assignees
No one assigned
Labels
area: next semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle