New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set team scope using --team
flag
#852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a-m-a-z-i-n-g
src/now.js
Outdated
const {team} = argv | ||
|
||
if (team.length === 0) { | ||
console.log(error(`You defined ${`--team`}, but it's missing a value`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use param
💅
src/now.js
Outdated
if (!token) { | ||
console.log(error(`You defined ${param(hasToken)}, but it\'s missing a value`)) | ||
if (token.length === 0) { | ||
console.error(error(`You defined ${`--token`}, but it's missing a value`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use param
💅
src/now.js
Outdated
await exit(1) | ||
} | ||
|
||
if (body.error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's check if it's e.g. HTTP 403
and show not authorized to access such team
or sth? 🙏
Just added all of @matheuss's suggestions! ✅ |
This allows the user to select the current scope for deploying. For example:
It will only work using the "sh" provider.